Skip to content

feat: Support cancellation notification while request timeout #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CrazyHZM
Copy link
Contributor

@CrazyHZM CrazyHZM commented Apr 12, 2025

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Sorry, something went wrong.

Signed-off-by: JermaineHua <crazyhzm@apache.org>
@CrazyHZM CrazyHZM changed the title feat: Support Cancellation Notification While request timeout feat: Support cancellation notification while request timeout Apr 12, 2025
@tzolov tzolov assigned tzolov and unassigned tzolov Apr 15, 2025
@chemicL
Copy link
Member

chemicL commented Apr 23, 2025

I am not sure we should send a cancellation notification for timeouts. Can you point me to the specification where it is mentioned timeouts should issue cancellation notifications? I agree cancellations should be supported, but I'm uncertain whether it should be automatically issued for timing out of requests.

@chemicL chemicL added the waiting for user Waiting for user feedback or more details label Apr 23, 2025
@CrazyHZM
Copy link
Contributor Author

CrazyHZM commented Apr 25, 2025

@chemicL
The specification does not indicate that a requirement notification needs to be sent when the timeout occurs, but I think this is a reasonable scenario for canceling the request because the client no longer cares about the response. I think it should be proposed as a specification when handling timeouts.
I created an issue to discuss this matter: modelcontextprotocol/modelcontextprotocol#418

@chemicL
Copy link
Member

chemicL commented May 5, 2025

@CrazyHZM thanks. I suggest we close the PR for now and feel free to reopen it if the issue for the spec update is resolved positively.

@chemicL chemicL closed this May 5, 2025
@chemicL chemicL removed the waiting for user Waiting for user feedback or more details label May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants